rethinking boost #1408
rethinking boost #1408
Conversation
There was a problem hiding this comment.
Looks good, played around with it and found an issue with comment boosts.
I also think we can do better with the icon. Flipping it only helps to distinguish it from zaps. But wouldn't be an arrow up be a better symbol for boosting? For example using arrow-up-double-line:
It looks a bit like a rank insignia which can be associated with boosting something.
| if (!failedInvoice) { | ||
| throw new Error(`retryPaidAction - invoice not found or not in failed state ${actionType}`) | ||
| } |
There was a problem hiding this comment.
I see, this is related to #1381. Would be nice to include the invoice id in the error message. I also think mentioning the action type in the front makes more sense else it sounds like the action type is the failed state:
retryPaidAction ${actionType} - invoice ${invoiceId} not found or not in failed state
If we assume people are looking to boost, I agree. Zooming out, if we assume people aren't looking to boost, my guess is it'd be kind of annoying to look at yet another icon imo. |
|
Mhh, interesting reasoning. This isn't considered to be a different icon since it's not different enough? Btw, I also wondered if you wanted to use |
|
Yeah, I thought it looked similar enough. Maybe not according to 0xBitcoiner |
closes #1351
closes #194
This is done. It can be improved but it's good enough imo.
The intent here is to:
TODO
EXTRA TODO